Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cloudnative-pg metadata #3123

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

kishankumarnutanix
Copy link
Contributor

@kishankumarnutanix kishankumarnutanix commented Feb 7, 2025

What problem does this PR solve?:

The metadata yaml file for cloudnative-pg app has dependencies and category fields set to an empty array. The dependency field should be removed and category should be set as "general" if it is not categorized. 
Setting dependencies field as empty array [], causes UI to render empty name (see screenshot in the ticket), a bug in kommander-ui which is being tracked here .
For now, as we do for all other k-apps metadata, if the cloudnative-pg app has no dependencies it can be safely removed from the metadata yaml file. 

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105607

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added services/cloudnative-pg size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2025
@coveralls
Copy link

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13204755758

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 13203380287: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@kishankumarnutanix kishankumarnutanix self-assigned this Feb 7, 2025
@kishankumarnutanix kishankumarnutanix marked this pull request as ready for review February 7, 2025 02:25
@mhrabovcin mhrabovcin changed the title update cloudnative-pg category & dependencies metadata chore: update cloudnative-pg metadata Feb 7, 2025
@kishankumarnutanix kishankumarnutanix force-pushed the kk/update-cloudnative-pg-metadata branch from a3f4d10 to 4b5f85b Compare February 7, 2025 17:19
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2025
@kishankumarnutanix kishankumarnutanix enabled auto-merge (squash) February 7, 2025 17:24
@kishankumarnutanix kishankumarnutanix merged commit 444c4e1 into main Feb 7, 2025
22 checks passed
@kishankumarnutanix kishankumarnutanix deleted the kk/update-cloudnative-pg-metadata branch February 7, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off services/cloudnative-pg size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants